Add flag to detect-aws-credentials to allow missing keys#175
Merged
asottile merged 1 commit intopre-commit:masterfrom Feb 10, 2017
Merged
Add flag to detect-aws-credentials to allow missing keys#175asottile merged 1 commit intopre-commit:masterfrom
asottile merged 1 commit intopre-commit:masterfrom
Conversation
asottile
reviewed
Feb 10, 2017
Member
asottile
left a comment
asottile
left a comment
There was a problem hiding this comment.
Looks good! Some minor things and then I'll merge.
| 0.8.0 | ||
| ===== | ||
| - Add flag to allow aws detection to pass when no keys exist | ||
|
|
Member
There was a problem hiding this comment.
Don't bother with the changelog, I'll fill this out when I decide to make a release <3
| '--allow-missing-credentials', | ||
| dest='allow_missing_credentials', | ||
| action='store_true', | ||
| help=('Allow hook to pass when no credentials are detected.') |
In the event that there exists no configuration for AWS credentials and they are not exported in to the current environment, a flag may be passed to allow exiting the hook successfully. Resolves pre-commit#174 Signed-off-by: Mike Fiedler <miketheman@gmail.com>
miketheman
force-pushed
the
miketheman/allow-missing-aws
branch
from
d9abfd7 to
312e721
Compare
Contributor
Author
|
Comments addressed, thanks! |
asottile
approved these changes
Feb 10, 2017
Member
|
Thanks! |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the event that there exists no configuration for AWS credentials and
they are not exported in to the current environment, a flag may be
passed to allow exiting the hook successfully.
Resolves #174
Signed-off-by: Mike Fiedler miketheman@gmail.com